Updated validating VS toolset generic for different VS versions #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jainaashish
requested review from
nkolev92,
rrelyea,
PatoBeltran,
dominoFire and
zivkan
nkolev92
reviewed
Dec 4, 2018
|
Well, at least locally it does, the CI is having issues, so we'll hold off merging for now. |
|
There was a minor issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are multiple places in our common.ps1 or configure.ps1 which only uses dev15 specific version or env variables which is why it fails for dev16 at some machines. This PR will fix those instances to make it generic for any VS version.