Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported PR from mrahl from nuget/nuget-3 #26

Merged
merged 2 commits into from
Oct 13, 2015
Merged

Ported PR from mrahl from nuget/nuget-3 #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff64412
Added test for resolving versions when updating dependency package in…
mrahl May 5, 2015
a54cda2
Updated test to match the latest PackageResolver.Resolve
deepakaravindr Oct 13, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 101 additions & 0 deletions test/NuGet.Core.Tests/NuGet.Resolver.Test/ResolverTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,107 @@ public void ResolveActionsForSimpleUpdate()
Assert.Equal("2.0.0", packages["A"].Version.ToNormalizedString());
}

[Fact]
public void ResolveDependenciesForUpdatePackageRequiringUpdatedDependencyThatRequiresUpdatedDependentBySeparatePath()
{
// Arrange
// A -> [B, C]
// B -> [D]
// C -> [D]
// A
// / \
// B C
// \ /
// D

// Local:
// A 1.0 -> B [1.0, 2.0), C [1.0, 2.0)
// B 1.0 -> D [1.0, 2.0)
// C 1.0 -> D [1.0, 2.0)

// Remote:
// A 1.1 -> B [1.1, 2.0), C [2.0, 3.0)
// B 1.1 -> D [2.0, 3.0)
// C 2.0 -> D [2.0, 3.0)

// Update initiated on B, not A

var project = new List<PackageReference> {
new PackageReference(new PackageIdentity("A", NuGetVersion.Parse("1.0")), null),
new PackageReference(new PackageIdentity("B", NuGetVersion.Parse("1.0")), null),
new PackageReference(new PackageIdentity("C", NuGetVersion.Parse("1.0")), null),
new PackageReference(new PackageIdentity("D", NuGetVersion.Parse("1.0")), null)
};

var installed = new List<ResolverPackage>();
var sourceRepository = new List<ResolverPackage>();

var packageA1 =
CreatePackage("A", "1.0", new Dictionary<string, string>
{
{ "B", "[1.0, 2.0)" },
{ "C", "[1.0, 2.0)" }
});
installed.Add(packageA1);

var packageB1 =
CreatePackage("B", "1.0", new Dictionary<string, string>
{
{ "D", "[1.0, 2.0)" }
});
installed.Add(packageB1);

var packageC1 =
CreatePackage("C", "1.0", new Dictionary<string, string>
{
{ "D", "[1.0, 2.0)" }
});
installed.Add(packageC1);

var packageD1 = CreatePackage("D", "1.0");
installed.Add(packageD1);

var packageA11 =
CreatePackage("A", "1.1", new Dictionary<string, string>
{
{ "B", "[1.1, 2.0)" },
{ "C", "[2.0, 3.0)" }
});
sourceRepository.Add(packageA11);

var packageB11 =
CreatePackage("B", "1.1", new Dictionary<string, string>
{
{ "D", "[2.0, 3.0)"}
});
sourceRepository.Add(packageB11);

var packageC2 =
CreatePackage("C", "2.0", new Dictionary<string, string>
{
{ "D", "[2.0, 3.0)" }
});
sourceRepository.Add(packageC2);

var packageD2 = CreatePackage("D", "2.0");
sourceRepository.Add(packageD2);

// Act
var resolver = new PackageResolver();
var packageResolverContext
= CreatePackageResolverContext(DependencyBehavior.Lowest, installed, sourceRepository);

var solution = resolver.Resolve(packageResolverContext, CancellationToken.None).ToArray();
var packages = solution.ToDictionary(p => p.Id);

// Assert
Assert.Equal(4, solution.Length);
Assert.Equal("1.1.0", packages["A"].Version.ToNormalizedString());
Assert.Equal("1.1.0", packages["B"].Version.ToNormalizedString());
Assert.Equal("2.0.0", packages["C"].Version.ToNormalizedString());
Assert.Equal("2.0.0", packages["D"].Version.ToNormalizedString());
}

[Fact]
public void ResolvesLowestMajorHighestMinorHighestPatchVersionOfListedPackagesForDependencies()
{
Expand Down