Pack: Allow project reference version to be a VersionRange #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tibel
requested review from
dominoFire,
donnie-msft,
dtivel,
heng-liu,
kartheekp-ms,
nkolev92,
zivkan and
zkat
as code owners
nkolev92
reviewed
Oct 25, 2019
|
Hey @tibel sorry for the delay. Would you be able to rebase on top of latest dev? |
|
Rebased on latest dev |
nkolev92
approved these changes
Feb 12, 2020
|
Thanks for the contributing @tibel We hope to fix the underlying problem eventually but this unblocks at least some scenarios today. |
|
We badly need this. Currenty we are patching our packages after they have been packed by NuGet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#5556 (partially)
Regression: No
Fix
Having version ranges for package references is possible already.
But for project references only a minVersion is supported yet.
This change adds version range support for project references (but no floating versions).
This is not a complete fix for the mentioned issue, as it fixes only the blocking issue in PackTaskLogic. I think there is more discussion necessary on how to implement NuGet/Home#5556.
Testing/Validation
Tests Added: No
Reason for not adding tests: Where not sure if needed. There was no test for the feature before. Also I was not sure what I need to test this.
Validation: -