Clarify the when to use var coding guideline #3294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
requested review from
aortiz-msft,
cristinamanum,
dominoFire,
donnie-msft,
dtivel,
heng-liu,
kartheekp-ms,
rrelyea,
zivkan and
zkat
as code owners
|
Just to explain, I followed the Parse method and thought it was returning a different type. |
Can't say this hasn't happened to me before :D |
aortiz-msft
approved these changes
Mar 12, 2020
zkat
reviewed
Mar 12, 2020
zivkan
approved these changes
Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/208
Regression: No
Fix
Details: In #3247 (comment) myself and @donnie-msft had a discussion about the interpretation of the when to use var rule.
Here's my take on it.
Adding 2 examples that I think are valid.
I'll be happy to modify the PR based on the direction the discussions goes into.
Testing/Validation
Tests Added: No
Reason for not adding tests: doc update.
Validation: