check contentFiles and different alias inference #3686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkat
force-pushed
the
dev-zkat-net5.0-pack-tests
branch
from
f836c87 to
5673bdb
Compare
zkat
force-pushed
the
dev-zkat-net5.0-pack-tests
branch
from
5673bdb to
5c815e1
Compare
nkolev92
approved these changes
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: No issue, just an extension of NuGet/Home#10020
Regression: No
Fix
This adds some detail to the unit test for packing with aliases to cover the following scenarios:
<Content ... /><None Include=... />net50-windows-like alias, instead ofnet5.0-windowsTesting/Validation
Tests Added: Yes
Validation: I've run the tests, and also tested these same scenarios manually.