NuGet.Client VSIX migration to new interop assemblies #3999
Conversation
… Microsoft.VisualStudio.Imaging.Interop.ImageMoniker
…ageManagement.VisualStudio.Test and NuGet.SolutionRestoreManager.Test
…ell.embeddable to v*.1112
…d property for Microsoft.VisualStudio.ProjectSystem.Managed* version to keep PackageDownloads in sync
…dd3 which is based on MS.VS.Interop 1112
This reverts commit 9310fa2.
…Projects changes?
| <PackageReference Update="Microsoft.VisualStudio.Language.Intellisense" Version="16.10.31" /> | ||
| <PackageReference Update="Microsoft.VisualStudio.Language.StandardClassification" Version="16.10.31" /> | ||
| <PackageReference Update="Microsoft.VisualStudio.Editor" Version="17.0.24-g4265d215ae" /> | ||
| <PackageReference Update="Microsoft.VisualStudio.Imaging.Interop.14.0.DesignTime" Version="14.3.26931" NoWarn="NU1605" /> |
There was a problem hiding this comment.
NoWarn/ExcludeAssets/IncludeAssets should not be set in the packages.targets file cause it messes with visibility.
See: https://github.com/NuGet/NuGet.Client/blob/dev/build/packages.targets for example, it contains none of these metadata items.
There was a problem hiding this comment.
Note that I understand that this is something we're trying to get done sooner than later, so I'm not necessarily asking for a change, but rather that we should create an issue.
There was a problem hiding this comment.
@nkolev92 Understood. There are still hacks here. Some of them may not even be needed anymore. To give you some context, I only had my first successful lab build yesterday and I have no way to test these changes in VS. So everything is still rough.
The goal of this PR is just to produce packages that will unblock the interop work of other teams since we're trying to have the interop work all-up completed by EOW. The initial PR in this branch was hacky and this one builds upon that one. There will be more changes coming.
- I would prefer not to create issues to track the remaining work here, but I will do so if that's what the team wants. In my mind it's all covered by https://github.com/NuGet/Client.Engineering/issues/754 which is not yet complete, even with this PR.
- I was hoping that once this work was complete I could create a PR to review and merge all of the interop-related changes from this branch into the "real" 6.0.x branch. Perhaps that doesn't make sense given the official-sounding name of this branch though. I wonder if @dtivel and @rrelyea had a long-term branch plan for this work. Perhaps calling the target branch release-6.0.x was a mistake? Or perhaps it was necessary so the right things (release things) would happen when changes were made in this branch.
There was a problem hiding this comment.
Discussed offline.
We'll just review these changes in more detail when they are ported into the long term branch.
| <PackageReference Update="Microsoft.VisualStudio.Text.Logic" Version="17.0.24-g4265d215ae" /> | ||
| <PackageReference Update="Microsoft.VisualStudio.Text.UI" Version="17.0.24-g4265d215ae" /> | ||
| <PackageReference Update="Microsoft.VisualStudio.Text.UI.Wpf" Version="17.0.24-g4265d215ae" /> | ||
| <PackageReference Update="Microsoft.VisualStudio.TextManager.Interop" Version="17.0.0-preview-1-31108-209" ExcludeAssets="all" PrivateAssets="all" /> |
| @@ -322,7 +322,8 @@ public async Task PackageExpander_Recovers_WhenStreamIsCorrupt() | |||
| } | |||
| } | |||
|
|
|||
| [Fact] | |||
| // ERIKD TODO REENABLE | |||
There was a problem hiding this comment.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/754
Regression? No
Description
Follow up to #3975 which was focused on NuGet.VisualStudio. This PR updates the rest of the NuGet.Client projects to consume the new VS interop assemblies.
Integration tests and functional tests have been disabled because they are not passing yet and the focus of this PR is to build a VSIX which can be inserted into the interop branch to unblock other teams.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation