Improve NuGetSdkResolver tests #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
nkolev92
approved these changes
Dec 10, 2021
erdembayar
reviewed
Dec 10, 2021
test/NuGet.Core.Tests/Microsoft.Build.NuGetSdkResolver.Test/GlobalJsonReader_Tests.cs
Show resolved
Hide resolved
erdembayar
reviewed
Dec 10, 2021
test/NuGet.Core.Tests/Microsoft.Build.NuGetSdkResolver.Test/GlobalJsonReader_Tests.cs
Show resolved
Hide resolved
jeffkl
commented
Dec 10, 2021
| { | ||
| // In MSBuild 15.9, the SdkResolverContext has an Interactive property. The value will be gotten through reflection so the MSBuild | ||
| // references do not need to be updated. | ||
| private static readonly PropertyInfo SdkResolverContextInteractivePropertyInfo = typeof(SdkResolverContext).GetRuntimeProperty("Interactive"); |
There was a problem hiding this comment.
This was removed because I added it before the corresponding change in MSBuild was available via a NuGet package. We've long since consumed a newer version that has the property so we don't need to use reflection anymore.
erdembayar
approved these changes
Dec 10, 2021
In preparation of improving the NuGetSdkResolver, the test coverage should be improved. Fixes NuGet/Home#11442
…n-Windows by creating files in the package
jeffkl
force-pushed
the
dev-jeffkl-improve-sdk-resolver-tests
branch
from
2485574 to
4e43152
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11442
Regression? Last working version:
Description
In preparation of improving the NuGetSdkResolver, the test coverage should be improved.
Changes:
TryGetPathOfFileAbove()method inGlobalJsonReaderand add unit testsNuGetSdkLoggerand add unit testsNuGetSdkResolverandGlobalJsonReaderPR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation