Pin Microsoft.Build and Microsoft.Extensions.CommandLineUtils.Sources versions for source-build #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… versions in source-build
ghost
added
the
|
cc @crummel |
nkolev92
approved these changes
May 24, 2022
zivkan
approved these changes
May 24, 2022
|
It's usually on the Assignee to merge this cc @dominoFire |
dominoFire
approved these changes
Jun 2, 2022
|
Thank you for your contribution, @MichaelSimons ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: dotnet/source-build#2878
Regression: Caused by #4404
Description
This fix is needed so that the NuGet.Client build doesn't pickup the latest versions of these packages during source-build. Getting the latest version caused prebuilts and source-build breaks. This gets source-build to build NuGet.Client closer to the way the Microsoft build works.
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation