Onboard to central package management in NuGet.Client repo #4899
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/1969
Regression? Last working version:
Description
git mv
onpackages.targets
but I changed too much of the contents so it looks like a delete/add 😢Directory.Packages.props
GlobalPackageReference
items forPackageReference
items that were in common imports<PackageReference />
instead of<PackageDownload />
since CPM doesn't support PackageDownload. This brought in new dependencies which weren't being pulled in before so I had to resolve all of the conflicts with a few new package versions and/orPrivateAssets
/ExcludeAssets
.GeneratePathProperty
in a few placesproject.json
inTest.Utility
since I think they were removed from newer versions ofMicrosoft.VisualStudio.ProjectSystem.Managed
. They are just usingComImport
so it should be okay.Directory.Packages.props
to the.test
folderPR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation