Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved performance and fixed how the PrivateAssets flow to transitively pinned centrally managed dependencies #4947

Closed
wants to merge 1 commit into from
Closed

Improved performance and fixed how the PrivateAssets flow to transitively pinned centrally managed dependencies #4947

wants to merge 1 commit into from

Conversation

marcin-krystianc
Copy link
Contributor

@marcin-krystianc marcin-krystianc commented Nov 23, 2022 •
edited
Loading

Bug

Fixes: NuGet/Home#12270, NuGet/Home#12269

Follows up the #4669

Description

..work in progress..

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@marcin-krystianc marcin-krystianc requested a review from a team as a code owner November 23, 2022 14:16
@ghost ghost added the Community PRs created by someone not in the NuGet team label Nov 23, 2022
@erdembayar
Copy link
Contributor

@marcin-krystianc
Description states "..work in progress..". Is it ready for review or not? If yes, please update the description.

@nkolev92
Copy link
Member

nkolev92 commented Nov 23, 2022 •
edited
Loading

Thanks for the contribution @marcin-krystianc

I also see 2 different issues are being addressed by this PR, one a functional, the other one a perf issue. Any chance those can be split into separate PRs to make reviewing easier?

@marcin-krystianc
Copy link
Contributor Author

marcin-krystianc commented Nov 24, 2022 •
edited
Loading

Description states "..work in progress..". Is it ready for review or not? If yes, please update the description.

Yes, sorry I didn't manage to finish the description yesterday. Also, I realized that it is not possible to convert it into a draft PR (for a reason which is unknown to me).
I think that @nkolev92 is right, this PR should be split into smaller changes that can be reviewed separately.

@marcin-krystianc marcin-krystianc marked this pull request as draft November 24, 2022 08:04
@marcin-krystianc
Copy link
Contributor Author

Opening smaller PRs, the first one is #4950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Community PRs created by someone not in the NuGet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PrivateAssets flow incorrectly to transitively pinned centrally managed dependencies
3 participants
@marcin-krystianc @erdembayar @nkolev92