-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Vulnerable label in versions combobox #5185
Conversation
@martinrrm could you try shrinking the details pane to its min size and let us know how's the wrapping? PLOC testing would be ideal, including with minimum supported screen resolution. You can be the first to try my PLOC testing guide (you're welcome :D) Also, I imagine this string works fine but please test with AccessibilityInsights and Narrator to ensure 'Vulnerable' and 'Vulnerable, Deprecated' are announced appropriately. |
Tested Narrator and AccessibilityInsights, both passed 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the PLOC & A11y testing.
It'd be great if a separate PR could add tests to DetailControlModelTests
to hit some edge cases. Ideally that would happen in 17.7 Preview 2 or 3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! LGTM.
@donnie-msft Added Accessibility Insights results |
Bug
Fixes: NuGet/Home#11127
Regression? Last working version:
Description
Added a label to the versions combobox to show when a package is Vulnerable or Vulnerable and deprecated. (Deprecated label already exists).
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation