Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Vulnerable label in versions combobox #5185

Merged
merged 2 commits into from
May 30, 2023

Conversation

martinrrm
Copy link
Contributor

Bug

Fixes: NuGet/Home#11127

Regression? Last working version:

Description

Added a label to the versions combobox to show when a package is Vulnerable or Vulnerable and deprecated. (Deprecated label already exists).

image

image

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception - Adding tests was getting too complicated and I think this is a simple UI change that can be validated manually.
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@martinrrm martinrrm requested a review from a team as a code owner May 24, 2023 17:51
@martinrrm martinrrm changed the title Dev martinrrm vulnerable version combobox Show Vulnerable label in versions combobox May 24, 2023
@donnie-msft
Copy link
Contributor

@martinrrm could you try shrinking the details pane to its min size and let us know how's the wrapping? PLOC testing would be ideal, including with minimum supported screen resolution. You can be the first to try my PLOC testing guide (you're welcome :D)

Also, I imagine this string works fine but please test with AccessibilityInsights and Narrator to ensure 'Vulnerable' and 'Vulnerable, Deprecated' are announced appropriately.

@martinrrm
Copy link
Contributor Author

Tested Narrator and AccessibilityInsights, both passed 🎉

@martinrrm
Copy link
Contributor Author

image
PLOC seems to be working

Copy link
Contributor

@donnie-msft donnie-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the PLOC & A11y testing.
It'd be great if a separate PR could add tests to DetailControlModelTests to hit some edge cases. Ideally that would happen in 17.7 Preview 2 or 3.

Copy link
Contributor

@jebriede jebriede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! LGTM.

@martinrrm martinrrm merged commit f3bb337 into dev May 30, 2023
@martinrrm martinrrm deleted the dev-martinrrm-vulnerable-version-combobox branch May 30, 2023 20:17
@martinrrm
Copy link
Contributor Author

@donnie-msft Added Accessibility Insights results
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Show which package versions are vulnerable in the VS PMUI package details pane version dropdown
4 participants