Do not warn http sources in push/delete scenarios when allowInsecureConnections is set to true. #5381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Aug 28, 2023
aortiz-msft
approved these changes
Aug 28, 2023
| (packageSource.ProtocolVersion == 3 || packageSource.Source.EndsWith("json", StringComparison.OrdinalIgnoreCase))) | ||
| { | ||
| logger.LogWarning(string.Format(CultureInfo.CurrentCulture, Strings.Warning_HttpServerUsage, "delete", packageSource.Source)); | ||
| } | ||
| var packageUpdateResource = await CommandRunnerUtility.GetPackageUpdateResource(sourceProvider, packageSource); | ||
|
|
||
| bool allowInsecureConnections = packageSource.AllowInsecureConnections; |
There was a problem hiding this comment.
Suggestion: just pass packageSource.AllowInsecureConnections directly in line 46 without new variable allowInsecureConnections
Comment on lines
2583
to
2584
| string expectedSymbolWarning = $"WARNING: You are running the 'push' operation with an 'HTTP' source, '{pushSymbolsUri}/'"; | ||
| if (isHttpWarningExpected) |
There was a problem hiding this comment.
NIT: Could we add an empty line before this line?
There was a problem hiding this comment.
Added an empty line. Thanks!
aortiz-msft
approved these changes
Aug 29, 2023
heng-liu
added a commit
that referenced
this pull request
Sep 8, 2023
…onnections is set to true. (#5381)
heng-liu
added a commit
that referenced
this pull request
Sep 8, 2023
…onnections is set to true. (#5381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12789
Regression? Last working version:
Description
When
allowInsecureConnectionsproperty in packageSources section is set to true in NuGet.Config files, do not warn for HTTP sources in push/delete scenarios.For push scenario, set
allowInsecureConnectionsproperty to true for push source will opt out the http warning for both package and symbol source.The PR enable the HTTP warnings in this scenario is: #4552
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation