Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add doc on localizability #5408

Merged
merged 3 commits into from
Sep 8, 2023
Merged

Docs: add doc on localizability #5408

merged 3 commits into from
Sep 8, 2023

Conversation

dtivel
Copy link
Contributor

@dtivel dtivel commented Sep 7, 2023

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/2477

Regression? Last working version: N/A

Description

This change adds a document describing resource commenting and how to lock strings.

CC @zivkan

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A
  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@dtivel dtivel requested a review from a team as a code owner September 7, 2023 18:13
nkolev92
nkolev92 previously approved these changes Sep 7, 2023
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great write-up!

I haven't replicated all the steps to confirm they work correctly, but the description contains plenty of detail! If anyone encounters problems, they can update these instructions then.

docs/localizability.md Show resolved Hide resolved
docs/localizability.md Show resolved Hide resolved
zivkan
zivkan previously approved these changes Sep 8, 2023
docs/localizability.md Outdated Show resolved Hide resolved
docs/localizability.md Show resolved Hide resolved
Co-authored-by: Donnie Goodson <49205731+donnie-msft@users.noreply.github.com>
@dtivel dtivel merged commit 83912bc into dev Sep 8, 2023
@dtivel dtivel deleted the dev-dtivel-localizability-doc branch September 8, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants