Enable central package management implicitly when Directory.Packages.props exists

[jeffkl]

Bug

Fixes: NuGet/Home#11834

Regression? Last working version:

Description

This change makes it so the presence of a Directory.Packages.props means that central package management is implicitly on. I've had countless people ask over the last year why you have to have the file and explicitly set ManagePackageVersionsCentrally to true. The logic now assumes if Directory.Packages.props exists then ManagePackageVersionsCentrally should be true unless the user has already set that property to a value, including if its set in Directory.Packages.props. This will make it easier for customers to onboard.

PR Checklist

• PR has a meaningful title

• PR has a linked issue.

• Described changes

• Tests

  • Automated tests added
  • OR
  • Test exception
  • OR
  • N/A

• Documentation

  • Documentation PR or issue filled
  • OR
  • N/A

[kartheekp-ms]

I found it difficult to understand the XML syntax while reviewing this pull request, so I have pasted the formatted XML here in case it helps to quickly grasp the changes.

<PropertyGroup Condition="'$(ManagePackageVersionsCentrally)' != 'false' And '$(ImportDirectoryPackagesProps)' != 'false' And '$(DirectoryPackagesPropsPath)' == ''">
  <_DirectoryPackagesPropsFile Condition="'$(_DirectoryPackagesPropsFile)' == ''">
    Directory.Packages.props
  </_DirectoryPackagesPropsFile>
  <_DirectoryPackagesPropsBasePath Condition="'$(_DirectoryPackagesPropsBasePath)' == ''">
    $([MSBuild]::GetDirectoryNameOfFileAbove('$(MSBuildProjectDirectory)', '$(_DirectoryPackagesPropsFile)'))
  </_DirectoryPackagesPropsBasePath>
  <DirectoryPackagesPropsPath Condition="'$(_DirectoryPackagesPropsBasePath)' != '' and '$(_DirectoryPackagesPropsFile)' != ''">
    $([MSBuild]::NormalizePath('$(_DirectoryPackagesPropsBasePath)', '$(_DirectoryPackagesPropsFile)'))
  </DirectoryPackagesPropsPath>
</PropertyGroup>

[zivkan]

@kartheekp-ms if you have github configured to use "unified" diffs, consider changing to "split":

[kartheekp-ms]

How about just checking <PropertyGroup Condition="'$(ManagePackageVersionsCentrally)' == 'true' > because ManagePackageVersionsCentrally is only true only when '$(ImportDirectoryPackagesProps)' != 'false' And Exists('$(DirectoryPackagesPropsPath)')?

[ghost]

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.