Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize file names to lowercase ID and version #557

Merged
merged 1 commit into from
May 17, 2016
Merged

Conversation

joelverhagen
Copy link
Member

@joelverhagen joelverhagen commented May 3, 2016

Changes readers and writers of the global packages folder or V2 style packages folder to make the ID and version component of the path lowercase.

.nupkgs written to package folders have file names {id-lower}.{version-lower}.nupkg, unless we are writting a V2 package folder (e.g. nuget.exe install) with -ExcludeVersion. Then the format is {id-lower}.nupkg.

.nuspec files have file names {id-lower}.nuspec.

Previously, the path to the .nupkg for Newtonsoft.Json 8.0.3 installed locally on Windows would look something like this:

C:\Users\jver\.nuget\packages\Newtonsoft.Json\8.0.3\Newtonsoft.Json.8.0.3.nupkg

After the change, this would look like:

C:\Users\jver\.nuget\packages\newtonsoft.json\8.0.3\newtonsoft.json.8.0.3.nupkg

@emgarten @alpaix @yishaigalatzer @rrelyea

@joelverhagen joelverhagen changed the title [WIP] Normalize file names to lowercase ID and version in V3 resources [WIP] Normalize file names to lowercase ID and version May 3, 2016
@emgarten
Copy link
Member

emgarten commented May 3, 2016

This looks way better than the previous normalization 😄 Check the xunit functional tests also if you haven't.

:shipit:

@joelverhagen joelverhagen force-pushed the jver-lower branch 2 times, most recently from b0ef79a to 2ba83dc Compare May 4, 2016 15:07
@joelverhagen joelverhagen changed the title [WIP] Normalize file names to lowercase ID and version Normalize file names to lowercase ID and version May 4, 2016
@joelverhagen joelverhagen force-pushed the jver-lower branch 6 times, most recently from c44b60a to bba6b74 Compare May 12, 2016 23:05
@joelverhagen joelverhagen force-pushed the jver-lower branch 2 times, most recently from fe4b7ff to 9579f9e Compare May 17, 2016 18:00
Update PackagePathResolver to use lowercase paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants