-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SDKAnalysisLevel and UsingMicrosoftNETSdk to packageSpec #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
reviewed
May 31, 2024
zivkan
reviewed
Jun 4, 2024
kartheekp-ms
reviewed
Jun 7, 2024
Nigusu-Allehu
force-pushed
the
dev-nyenework-sdk-analysis-level
branch
from
June 7, 2024 21:11
578030c
to
3594a62
Compare
Nigusu-Allehu
commented
Jun 7, 2024
Nigusu-Allehu
commented
Jun 7, 2024
Nigusu-Allehu
commented
Jun 7, 2024
zivkan
reviewed
Jun 13, 2024
zivkan
reviewed
Jun 13, 2024
Nigusu-Allehu
commented
Jun 13, 2024
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Outdated
Show resolved
Hide resolved
Nigusu-Allehu
changed the title
Add SDKAnalysisLevel to NuGet
Add SDKAnalysisLevel and UsingMicrosoftNETSdk to packageSpec
Jun 13, 2024
zivkan
reviewed
Jun 13, 2024
zivkan
reviewed
Jun 14, 2024
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Outdated
Show resolved
Hide resolved
zivkan
reviewed
Jun 14, 2024
zivkan
reviewed
Jun 14, 2024
jeffkl
reviewed
Jul 10, 2024
src/NuGet.Clients/NuGet.SolutionRestoreManager/VSNominationUtilities.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Build.Tasks.Console/MSBuildStaticGraphRestore.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Outdated
Show resolved
Hide resolved
...Get.PackageManagement.VisualStudio.Test/ProjectSystems/LegacyPackageReferenceProjectTests.cs
Outdated
Show resolved
Hide resolved
...Get.PackageManagement.VisualStudio.Test/ProjectSystems/LegacyPackageReferenceProjectTests.cs
Outdated
Show resolved
Hide resolved
jeffkl
previously approved these changes
Jul 10, 2024
nkolev92
reviewed
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor comments.
src/NuGet.Clients/NuGet.SolutionRestoreManager/VSNominationUtilities.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
Outdated
Show resolved
Hide resolved
...Get.PackageManagement.VisualStudio.Test/ProjectSystems/LegacyPackageReferenceProjectTests.cs
Outdated
Show resolved
Hide resolved
jeffkl
previously approved these changes
Jul 11, 2024
nkolev92
previously approved these changes
Jul 11, 2024
nkolev92
reviewed
Jul 11, 2024
zivkan
previously approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think there's scope for improvement, but nothing blocking.
zivkan
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13309
Regression? Last working version:
Description
SDKAnalysisLevel
value inMicrosoft.NETCoreSdk.BundledVersions.props
which is consumed early by msbuild. This is then consumed during restore.SdkAnalysisLevel
andUsingMicrosoftNetSdk
and have them ready in package spec of a project.dotnet / msbuild
src/NuGet.Core/NuGet.Commands/RestoreCommand/Utility/MSBuildRestoreUtility.cs
to get the dgspec content, updateMsbuildRestoreUtility
to getSdkAnalysisLevel
andUsingMicrosoftNETSdk
properties.nuget.exe
SDKAnalysisLevel
andUsingMicrosoftNETSdk
which will then be consumed by nuget.exe restore command and then passed to the restore runner similar to dotnet /msbuild restore.the dgspec file would looks as follows
VS
SdkAnalysisLevel
andUsingMicrosoftNETSdk
values and add them to the corresponding projectpackageSpec
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation
https://github.com/Create a documentation for HTTP errors introduced for insecure sources Home#13603