Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure narrator reads source errors and warnings correctly when listing package sources in PMUI #5863

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Make sure narrator reads source errors and warnings correctly when listing package sources in PMUI #5863

merged 1 commit into from
Jun 19, 2024

Conversation

Nigusu-Allehu
Copy link
Contributor

@Nigusu-Allehu Nigusu-Allehu commented Jun 18, 2024 •
edited
Loading

Bug

Fixes: NuGet/Home#13555

Regression? Last working version:

Description

This PR makes sure the narrator reads the right error message based on the value allowInsecureConnections

  • previously the information was not being propagated as a result the narrator always reads http warnings even when it is not supposed to.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner June 18, 2024 17:29
@Nigusu-Allehu Nigusu-Allehu self-assigned this Jun 19, 2024
donnie-msft
donnie-msft approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@donnie-msft donnie-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about this a few days ago and my understanding was that the problem being fixed is nothing specific to Narrator, just a logic bug due to the missing value which applies to all screen-readers.

@Nigusu-Allehu Nigusu-Allehu merged commit 79e6e48 into dev Jun 19, 2024
27 of 28 checks passed
@Nigusu-Allehu Nigusu-Allehu deleted the dev-neyenework-pmui-source-list-accessibility branch June 19, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnie-msft donnie-msft donnie-msft approved these changes

@jeffkl jeffkl jeffkl approved these changes

@jebriede jebriede jebriede approved these changes

@nkolev92 nkolev92 nkolev92 approved these changes

Assignees

@Nigusu-Allehu Nigusu-Allehu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Narator does not read the value of allowInsecureConnections
5 participants
@Nigusu-Allehu @nkolev92 @jebriede @jeffkl @donnie-msft