Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NuGet.Packaging.Core #5870

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Remove NuGet.Packaging.Core #5870

merged 3 commits into from
Jun 24, 2024

Conversation

nkolev92
Copy link
Member

@nkolev92 nkolev92 commented Jun 21, 2024 •
edited
Loading

Bug

Fixes: NuGet/Home#13385

Regression? Last working version:

Description

In NuGet/Home#12495 we stopped publishing NuGet.Packaging.Core.
There's been no feedback on that, so I think it's safe to remove.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@nkolev92 nkolev92 requested a review from a team as a code owner June 21, 2024 17:35
jeffkl
jeffkl previously approved these changes Jun 21, 2024
View reviewed changes
NuGet.sln Show resolved Hide resolved
@nkolev92 nkolev92 requested a review from jeffkl June 21, 2024 20:21
jeffkl
jeffkl previously approved these changes Jun 21, 2024
View reviewed changes
donnie-msft
donnie-msft previously approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@donnie-msft donnie-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You win Most Deleted Code PR for the week!
Can this apply to servicing branches as well? I know the team didn't want to put a servicing branch checklist, so please put it in the description or a comment why we are/are not servicing this change.

@nkolev92
Copy link
Member Author

I'm not sure I see a reason why this needs to be serviced. It's like any code removal.

@nkolev92 nkolev92 dismissed stale reviews from donnie-msft and jeffkl via 6ff7edd June 21, 2024 23:20
@nkolev92 nkolev92 enabled auto-merge (squash) June 24, 2024 05:21
@nkolev92 nkolev92 merged commit 9db78fb into dev Jun 24, 2024
28 checks passed
@nkolev92 nkolev92 deleted the dev-nkolev92-removeNuGetPackagingCore branch June 24, 2024 05:55
@ellahathaway ellahathaway mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnie-msft donnie-msft donnie-msft approved these changes

@zivkan zivkan zivkan approved these changes

@jeffkl jeffkl Awaiting requested review from jeffkl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove NuGet.Packaging.Core code
4 participants
@nkolev92 @zivkan @jeffkl @donnie-msft