Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update darc BAR tokens authentication method #5957

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

martinrrm
Copy link
Contributor

Bug

Fixes: NuGet/Home#13656

Description

We were asked to change how we get the BAR id, the linked issue suggested these code changes.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • [] Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@martinrrm martinrrm requested a review from a team as a code owner August 6, 2024 17:41
@aortiz-msft aortiz-msft requested a review from zivkan August 6, 2024 22:37
Copy link

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Please note that you will need your internal pipeline approved for use of the service connection. Once the internal build runs, it will block on the approval until an admin from your AzDO (devdiv or dnceng?) org approves.

Comment on lines +408 to +409
inlineScript: |
dotnet msbuild $(Build.Repository.LocalPath)\build\publish.proj /t:PublishToBuildAssetRegistry /property:NuGetClientNupkgsDirectoryPath=$(Build.Repository.LocalPath)\artifacts\$(NupkgOutputDir) /property:BUILD_BUILDNUMBER=$(Build.BuildNumber) /property:BUILD_SOURCEBRANCH=$(Build.SourceBranchName) /property:BUILD_SOURCEVERSION=$(Build.SourceVersion) /property:BUILD_REPOSITORY_URI=$(Build.Repository.Uri) /property:BUILD_REPOSITORY_NAME=$(Build.Repository.Name) /property:ArtifactsLogDir=$(Build.Repository.LocalPath)\artifacts\manifests\ /binarylogger:$(Build.StagingDirectory)\binlog\21.PublishToBuildAssetRegistry.binlog
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI you can do this in YAML:

Suggested change
inlineScript: |
dotnet msbuild $(Build.Repository.LocalPath)\build\publish.proj /t:PublishToBuildAssetRegistry /property:NuGetClientNupkgsDirectoryPath=$(Build.Repository.LocalPath)\artifacts\$(NupkgOutputDir) /property:BUILD_BUILDNUMBER=$(Build.BuildNumber) /property:BUILD_SOURCEBRANCH=$(Build.SourceBranchName) /property:BUILD_SOURCEVERSION=$(Build.SourceVersion) /property:BUILD_REPOSITORY_URI=$(Build.Repository.Uri) /property:BUILD_REPOSITORY_NAME=$(Build.Repository.Name) /property:ArtifactsLogDir=$(Build.Repository.LocalPath)\artifacts\manifests\ /binarylogger:$(Build.StagingDirectory)\binlog\21.PublishToBuildAssetRegistry.binlog
inlineScript: >
dotnet msbuild $(Build.Repository.LocalPath)\build\publish.proj /t:PublishToBuildAssetRegistry
/property:NuGetClientNupkgsDirectoryPath=$(Build.Repository.LocalPath)\artifacts\$(NupkgOutputDir)
/property:BUILD_BUILDNUMBER=$(Build.BuildNumber)
/property:BUILD_SOURCEBRANCH=$(Build.SourceBranchName)
/property:BUILD_SOURCEVERSION=$(Build.SourceVersion)
/property:BUILD_REPOSITORY_URI=$(Build.Repository.Uri)
/property:BUILD_REPOSITORY_NAME=$(Build.Repository.Name)
/property:ArtifactsLogDir=$(Build.Repository.LocalPath)\artifacts\manifests\
/binarylogger:$(Build.StagingDirectory)\binlog\21.PublishToBuildAssetRegistry.binlog

@dotnet-policy-service dotnet-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Aug 14, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has no activity for 7 days. It will be closed if no further activity occurs within another 7 days of this comment. If it is closed, you may reopen it anytime when you're ready again, as long as you don't delete the branch.

@martinrrm martinrrm merged commit 2507916 into dev Aug 14, 2024
28 checks passed
@martinrrm martinrrm deleted the dev-martinrrm-publishing-darc-remove-tokens branch August 14, 2024 21:22
jeffkl added a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publishing to BAR/Maestro will no longer support tokens
3 participants