Fix the reading of the legacy algorithm property #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
previously approved these changes
Aug 15, 2024
jeffkl
previously approved these changes
Aug 15, 2024
zivkan
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13700
Description
In the speed of merging f06d028#diff-243f52adff2a41b2195f19c88106dbcc830a2d8cc0f39b1ac39a5f444bfa3c0c, a scenario was missed.
The new property wasn't round trippable and the standard msbuild restore scenario did not respect the property (static graph, VS do).
This fixes that and adds tests to ensure we don't have this problem in the future.
PR Checklist
Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.