remove unnecessary using directives and sort the existing ones (IDE0005) #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartheekp-ms
changed the title
nkolev92
approved these changes
Aug 15, 2024
Nigusu-Allehu
approved these changes
Aug 15, 2024
kartheekp-ms
force-pushed
the
dev-kmps-codecleanup-remove-unused-usings
branch
from
2f85fa1 to
6dd1778
Compare
donnie-msft
approved these changes
Aug 20, 2024
kartheekp-ms
force-pushed
the
dev-kmps-codecleanup-remove-unused-usings
branch
from
6dd1778 to
8b1f6dd
Compare
nkolev92
approved these changes
Aug 20, 2024
Nigusu-Allehu
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2961
Description
I learnt that it is easy to
remove unnecessary using directivesusing Visual Studio's Code Cleanup feature. After selecting the fixers, I clicked onAnalyze > Code Cleanup > Run Code Cleanup (Profile 1) on Solutionwhich removed unnecessary and sorted the using directives across the entire solution. @jgonz120 is working on enabling IDE0005 analyzer on build https://github.com/NuGet/Client.Engineering/issues/2845 so we don't end up adding new violations.PR Checklist
Added tests