-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize the performance scripts - add the ability to test a locally built NuGet #5974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
added
the
Engineering
Changes related to the build infrastructure of the repo and that do not change product code
label
Aug 15, 2024
zivkan
previously approved these changes
Aug 16, 2024
jebriede
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: There's a mix of casing for If and Else throughout. LGTM otherwise! Approving.
@@ -479,9 +484,44 @@ Function RunRestore( | |||
$staticGraphOutputValue = "N/A" | |||
} | |||
|
|||
$stopwatch = [System.Diagnostics.Stopwatch]::StartNew() | |||
If($isClientDotnetExe -Or $isClientMSBuild) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: capital If inconsistent with others.
Suggested change
If($isClientDotnetExe -Or $isClientMSBuild) | |
if($isClientDotnetExe -Or $isClientMSBuild) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Engineering
Changes related to the build infrastructure of the repo and that do not change product code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2962
Description
For reference here's the command that I've been running from the root of my local repo:
Here's how test run results look after that.
OrchardCore-git.csv
NuGet-Client-git.csv
PR Checklist
Added testsLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.