Discover plugins installed using Net tools

src/NuGet.Core/NuGet.Protocol/NuGet.Protocol.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
- <TargetFrameworks>$(TargetFrameworksLibraryForSigning)</TargetFrameworks>
+ <TargetFrameworks>$(TargetFrameworksLibraryForSigning);$(NETCoreTargetFramework)</TargetFrameworks>
  <TargetFramework />
  <NoWarn>$(NoWarn);CS1591;CS1573;CS0012;RS0041</NoWarn>
  <PackageTags>nuget protocol</PackageTags>

src/NuGet.Core/NuGet.Protocol/Plugins/PluginDiscoverer.cs

@@ -3,7 +3,10 @@
 
 using System;
 using System.Collections.Generic;
+using System.Diagnostics;
 using System.IO;
+using System.Linq;
+using System.Runtime.InteropServices;
 using System.Threading;
 using System.Threading.Tasks;
 using NuGet.Common;
@@ -140,6 +143,105 @@ private List<PluginFile> GetPluginFiles(CancellationToken cancellationToken)
  return files;
  }
 
+ /// <summary>
+ /// Gets auth plugins installed using dotnet tools. This is done by iterating through each file in directories found int eh
+ /// `PATH` environment variable.
+ /// The files are also expected to have a name that starts with `nuget-plugin-`
+ /// </summary>
+ /// <returns></returns>
+ private static List<string> GetNetToolsPluginFiles()
+ {
+ var pluginFiles = new List<string>();
+ var paths = Environment.GetEnvironmentVariable("PATH")?.Split(Path.PathSeparator) ?? Array.Empty<string>();
+
+ foreach (var path in paths)
+ {
+ if (Directory.Exists(path))
+ {
+ var directoryInfo = new DirectoryInfo(path);
+ var files = directoryInfo.GetFiles("nuget-plugin-*");
+
+ foreach (var file in files)
+ {
+ if (IsValidPluginFile(file))
+ {
+ pluginFiles.Add(file.FullName);
+ }
+ }
+ }
+ }
+
+ return pluginFiles;
+ }
+
+ /// <summary>
+ /// Checks whether a file is a valid plugin file for windows/Unix.
+ /// Windows: It should be either .bat or .exe
+ /// Unix: It should be executable
+ /// </summary>
+ /// <param name="fileInfo"></param>
+ /// <returns></returns>
+ private static bool IsValidPluginFile(FileInfo fileInfo)
+ {
+ if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+ {
+ return fileInfo.Extension.Equals(".exe", StringComparison.OrdinalIgnoreCase) ||
+ fileInfo.Extension.Equals(".bat", StringComparison.OrdinalIgnoreCase);
+ }
+ else
+ {
+#if NET8_0
+ var fileMode = File.GetUnixFileMode(fileInfo.FullName);
+
+ return fileInfo.Exists &&
+ ((fileMode & UnixFileMode.UserExecute) != 0 ||
+ (fileMode & UnixFileMode.GroupExecute) != 0 ||
+ (fileMode & UnixFileMode.OtherExecute) != 0);
+#else
+ return fileInfo.Exists && (fileInfo.Attributes & FileAttributes.ReparsePoint) == 0 && IsExecutable(fileInfo);
+#endif
+ }
+ }
+
+ /// <summary>
+ /// Checks whether a file is executable or not in Unix.
+ /// This is done by running bash code: `if [ -x {fileInfo.FullName} ]; then echo yes; else echo no; fi`
+ /// </summary>
+ /// <param name="fileInfo"></param>
+ /// <returns></returns>
+ private static bool IsExecutable(FileInfo fileInfo)
+ {
+#pragma warning disable CA1031 // Do not catch general exception types
+ try
+ {
+ string output;
+ using (var process = new Process())
+ {
+ // Use a shell command to check if the file is executable
+ process.StartInfo.FileName = "/bin/bash";
+ process.StartInfo.Arguments = $"if [ -x {fileInfo.FullName} ]; then echo yes; else echo no; fi";
+ process.StartInfo.UseShellExecute = false;
+ process.StartInfo.RedirectStandardOutput = true;
+
+ process.Start();
+ if (!process.WaitForExit(1000) || process.ExitCode != 0)
+ {
+ return false;
+ }
+
+ output = process.StandardOutput.ReadToEnd().Trim();
+ }
+
+ // Check if the output is "yes"
+ return output.Equals("yes", StringComparison.OrdinalIgnoreCase);
+ }
+ catch
+ {
+ return false;
+ }
+#pragma warning restore CA1031 // Do not catch general exception types
+ }
+
  private IEnumerable<string> GetPluginFilePaths()
  {
  if (string.IsNullOrEmpty(_rawPluginPaths))
@@ -149,7 +251,12 @@ private IEnumerable<string> GetPluginFilePaths()
  // Internal plugins are only supported for .NET Framework scenarios, namely msbuild.exe
  directories.Add(PluginDiscoveryUtility.GetInternalPlugins());
 #endif
- return PluginDiscoveryUtility.GetConventionBasedPlugins(directories);
+ var plugins = PluginDiscoveryUtility.GetConventionBasedPlugins(directories).ToList();
+
+ // Get plugins added using .Net Tools
+ plugins.AddRange(GetNetToolsPluginFiles());
+
+ return plugins;
  }
 
  return _rawPluginPaths.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries);