-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover plugins installed using Net tools #5990
Open
Nigusu-Allehu
wants to merge
21
commits into
dev-feature-dot-net-tool-plugin-support
Choose a base branch
from
dev-nyenework-net-tools-plugin
base: dev-feature-dot-net-tool-plugin-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
4db9964
Discover Net tools installed plugins
Nigusu-Allehu bd202c4
Read unix executable plugins
Nigusu-Allehu b199f4e
Add tests
Nigusu-Allehu c48c415
cleanup
Nigusu-Allehu 859754a
Linux test
Nigusu-Allehu 2a9ed74
Linux test
Nigusu-Allehu c573bb9
Merge branch 'dev-nyenework-net-tools-plugin' of https://github.com/N…
Nigusu-Allehu f533021
Use GetUnixFileMode
Nigusu-Allehu 42ff98f
Fix test
Nigusu-Allehu bbdee18
white space
Nigusu-Allehu e7776f2
Add more tests
Nigusu-Allehu 405a28f
Merge branch 'dev-nyenework-net-tools-plugin' of https://github.com/N…
Nigusu-Allehu 7a6d5e9
fix tests
Nigusu-Allehu c4638c4
Comment
Nigusu-Allehu 8c51a6c
use /bin/bash
Nigusu-Allehu 1d7ba24
Fix assert
Nigusu-Allehu 425767e
Cleanup testing
Nigusu-Allehu 668ba03
Add NUGET_PLUGIN_PATHS
Nigusu-Allehu 1e2e41e
Clean code
Nigusu-Allehu a9fcab7
use empty body constructor
Nigusu-Allehu 561db34
NuGetPluginPaths Env variable used by dotnet tools only
Nigusu-Allehu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please help me understand the reasoning behind the
(fileInfo.Attributes & FileAttributes.ReparsePoint == 0)
check. My internet search suggested it is related to symbolic links, etc., but I happy to learn more.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. I wanted to ensure the file both exists and is a real file (not a symbolic link) to minimize the risk of running malicious code. For example, imagine a symbolic link located in one of the directories listed in the user's
PATH
environment variable. The link has a name likenuget-plugin-*
, making it appear like a normal plugin, but it actually points to a malicious file in a different directory. If we run that symlink, we unintentionally execute the malicious file from the other location. We could say it is up to the user to ensure there is no malicious files in the PATH folders. However, I don't see a reason why we should leave that vulnerability open.