First step to fetch transitive packages in Solution PM UI package list and installed tab vulnerability warning #5994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nerability warnings in Solution PM UI Installed Tab
martinrrm
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Looks good!
I was expecting more tests to break, maybe we should be running NuGet Client daily (Apex?) and the tests that are run after merging the PR to see if there everything is good.
Or maybe we should add more tests for transitive packages in Solution level
jebriede
merged commit 5fb049e
into
feature-TransitivePkgsInSolutionPMUI
28 checks passed
martinrrm
pushed a commit
that referenced
this pull request
Sep 23, 2024
…t and installed tab vulnerability warning (#5994) First step to show transitive packages in Solution PM UI and show vulnerability warnings in Solution PM UI Installed Tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13695
Description
This change enables the Solution-level PM UI to fetch transitive packages for showing in the packages list, and for determining if there are vulnerable packages in the Installed tab indicator. The Solution PM UI will no longer behave differently than the Project-level PM UI in that regard. There is still more work to be done to represent the package items and show vulnerability indicators in the package list which will come in related PRs for the feature.
PR Checklist