Revert "Address feedback from original change to introduce new dependency resolution algorithm" #6001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donnie-msft
approved these changes
Aug 30, 2024
kartheekp-ms
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit adfa38b.
Bug
Fixes: N/A
Description
Out VS insertion has been failing since #5980 was merged. Cloning the VS repo locally, using the latest NuGet.Client dev branch, trying to restore the VS repo is very, very slow (seriously, it took 90 minutes!), and eventually does reproduce the same error we're seeing the VS's pull request CI. This branch (reverting the commit), restore that doesn't need to download packages (no-op, except with
-p:RestoreForce=true), restore is fast (~3 minutes) and doesn't fail again.PR Checklist
Added testsreverting a commitLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.reverting a commit, plus no changes to customer behaviour