[Transitive's in Solution] Vulnerability indicators in solution level details pane for top-level packages #6010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinrrm
commented
Sep 4, 2024
| private IEnumerable<NuGetVersion> _vulnerableVersions = []; | ||
| public IEnumerable<NuGetVersion> VulnerableVersions | ||
| private Dictionary<NuGetVersion, int> _vulnerableVersions = []; | ||
| public Dictionary<NuGetVersion, int> VulnerableVersions |
There was a problem hiding this comment.
This were mistakenly added in the previous PR and were never used.
jebriede
requested changes
Sep 4, 2024
...uGet.Clients/NuGet.PackageManagement.UI/Converters/InstalledVulnerabilitiesCountConverter.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Converters/IntToVisibilityConverter.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/PackageSolutionDetailControlModel.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/PackageSolutionDetailControlModel.cs
Outdated
Show resolved
Hide resolved
jgonz120
reviewed
Sep 6, 2024
donnie-msft
approved these changes
Sep 9, 2024
src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/PackageItemViewModel.cs
Outdated
Show resolved
Hide resolved
jebriede
reviewed
Sep 10, 2024
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/PackageSolutionDetailControlModel.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/PackageSolutionDetailControlModel.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/PackageItemViewModel.cs
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Models/PackageSolutionDetailControlModel.cs
Outdated
Show resolved
Hide resolved
jebriede
approved these changes
Sep 13, 2024
Comment on lines
905
to
912
| if (maxSeverity > -1) | ||
| { | ||
| VulnerableVersions.Add(version, maxSeverity); | ||
| } | ||
|
|
||
| VulnerabilityMaxSeverity = Math.Max(VulnerabilityMaxSeverity, maxSeverity); | ||
|
|
||
| OnPropertyChanged(nameof(Status)); |
There was a problem hiding this comment.
For SetVulnerabilityMaxSeverity, would we want to only calculate and set the VulnerabilityMaxSeverity and call OnPropertyChanged if the maxSeverity is > -1?
martinrrm
force-pushed
the
dev-martinrrm-vulnerabilities-top-level-solution
branch
from
cc328a9 to
949ba9f
Compare
martinrrm
merged commit 34cc432
into
feature-TransitivePkgsInSolutionPMUI
28 checks passed
martinrrm
deleted the
dev-martinrrm-vulnerabilities-top-level-solution
branch
martinrrm
added a commit
that referenced
this pull request
Sep 23, 2024
… details pane for top-level packages (#6010) * Vulnerability indicators for top level in solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13760
Description
This PR enables calculating the vulnerabilities for all the packages that we have a metadata, in the previous PR for this feature we allowed the
PackageItemViewModelto have data for all the installed versions in the Solution and store a copy of that metadata.Vulnerability indicators are also being added to the Solution Detail Pane so users are able to identify vulnerable installed packages more easily.
PR Checklist