PackageManagementFormat only updates settings when it has a value #6016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jebriede
approved these changes
Sep 10, 2024
| new AddItem(ConfigurationConstants.DefaultPackageManagementFormatKey, _selectedPackageFormat.ToString(CultureInfo.InvariantCulture))); | ||
| _settings.AddOrUpdate(ConfigurationConstants.PackageManagementSection, | ||
| new AddItem(ConfigurationConstants.DoNotShowPackageManagementSelectionKey, _showDialogValue.Value.ToString(CultureInfo.InvariantCulture))); | ||
| if (_selectedPackageFormat != -1) |
There was a problem hiding this comment.
To guard against any future code changes that could use another sentinel value (like -2, etc), you could make this:
Suggested change
| if (_selectedPackageFormat != -1) | |
| if (_selectedPackageFormat > -1) |
zivkan
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13773
Description
While testing VS Settings, I found that if I do not invoke getters on properties in this class, then call
ApplyChangestwo issues can occur:Enabledproperty: an exception was thrown due to a nullable property being unsetSelectedPackageManagementFormatproperty: a "-1" was written to the nuget.config. This is never a valid value and should never be written to a nuget.configCheck properties for valid values prior to updating settings.
Tests ensure that if no values are set, nothing is updated in settings, even though the call to Save still occurs. I didn't want to change any other workflow that may depend on this call to save to disk.
PR Checklist