Properly handle missing package versions in new dependency resolver #6028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
added
the
Priority:1
nkolev92
reviewed
Sep 17, 2024
| @@ -650,6 +650,12 @@ async static (state) => | |||
| for (int i = 0; i < refItemResult.Item.Data.Dependencies.Count; i++) | |||
| { | |||
| var dep = refItemResult.Item.Data.Dependencies[i]; | |||
| // Packages with missing versions should not be added to the graph | |||
| if (dep.LibraryRange.VersionRange == null) | |||
There was a problem hiding this comment.
Do we need to make sure this isn't applied to the top-level project?
There was a problem hiding this comment.
For the top-level project, this will only be null if CPM is enabled and a version is missing. However, before this resolver is called, an error is logged and restore doesn't happen. This is only run if a transitive project isn't properly configured.
nkolev92
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13788
Description
During restore, NuGet verifies that CPM requirements are met by verifying all packages have versions. However, when one project references another and the referenced project has a missing package, NuGet logs an error for the referenced project but restores the other. It restores this project by skipping the dependency.
This change updates the new dependency resolver to ignore packages with missing versions.
PR Checklist