Update ProjectInstallationInfo ToString() on Details Pane table and improve localization of table headers #6051
Conversation
martinrrm
changed the title
There was a problem hiding this comment.
The max severity in the table should be localized.
The title, which becomes the commit messages, should state we're updating the ToString for accessibility. It's not quite accurate that we're updating Narrator for the details pane, we're actually updating the ToString so that any screen reader (including Narrator) will read the details correctly.
| var vulnerabilityString = string.Empty; | ||
| if (InstalledVersionMaxVulnerability != -1) | ||
| { | ||
| vulnerabilityString = string.Format(CultureInfo.CurrentCulture, Resources.Label_PackageVulnerableToolTip, (PackageVulnerabilitySeverity)InstalledVersionMaxVulnerability); |
There was a problem hiding this comment.
The InstalledVersionMaxVulnerability enum values are not localized. We use IntToVulnerabilitySeverityConverter in the XAML to convert to a localized string. We should consider localization for this accessibility fix.
There was a problem hiding this comment.
If im not wrong when we use CultureInfo it localizes the string.
I updated the code to use the converter, not sure if this is the best way to do it. We could also copy the code from the converter into this file.
martinrrm
changed the title
jebriede
merged commit aae9f6d
into
feature-TransitivePkgsInSolutionPMUI
Bug
Fixes: NuGet/Home#13805
Description
Narrator wasn't reading the whole table, we use the property ToString() in PackageInstallationInfo for that, now Narrator reads the vulnerability and the package level
PR Checklist
- [ ] Added testsNarrator tested