Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing a typo in the XAML binding for VulnerableVersions count #6056

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fixing a typo in the XAML binding for VulnerableVersions count #6056

merged 1 commit into from
Sep 26, 2024

Conversation

jebriede
Copy link
Contributor

Bug

Fixes: NuGet/Home#13216

Description

Fixing a typo in the XAML binding on vulnerable packages count. The period was accidentally removed and is being restored in this PR.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests XAML binding / UI change
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@jebriede jebriede requested a review from a team as a code owner September 26, 2024 00:13
@jebriede jebriede mentioned this pull request Sep 26, 2024
Merged
3 tasks
kartheekp-ms
kartheekp-ms approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@kartheekp-ms kartheekp-ms left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you have manually tested the impact of this change on PM UI.

@jebriede
Copy link
Contributor Author

jebriede commented Sep 26, 2024 •
edited
Loading

Solution PM UI

More than one vulnerable version of the package:
image

One vulnerable version of the package:
image

Project PM UI

More than one vulnerable version of the package:
Not applicable in Project PM UI

One vulnerable version of the package:
image

@jebriede jebriede enabled auto-merge (squash) September 26, 2024 00:21
@jebriede jebriede merged commit 6747f2e into dev Sep 26, 2024
28 checks passed
@jebriede jebriede deleted the dev-jebriede-FixTypoInVulnVersionsCount branch September 26, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartheekp-ms kartheekp-ms kartheekp-ms approved these changes

@jgonz120 jgonz120 jgonz120 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Enable Transitive Dependencies for Solution-level in Visual Studio
3 participants
@jebriede @jgonz120 @kartheekp-ms