Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap arguments order for centralized package version logs #6071

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

Nigusu-Allehu
Copy link
Contributor

@Nigusu-Allehu Nigusu-Allehu commented Oct 1, 2024

Bug

Fixes: NuGet/Home#13155

Description

This PR swaps arguments order for the localized string Info_AddPkgCPM

Currently it logs as follows:

info : PackageReference for package 'NAudio' added to '/some-project/src/Directory.Packages.props' and PackageVersion added to central package management file '/some-project/src/Web/UiComponents/Zezo.UiComponents.csproj'.

After this PR it will log as follows:

info : PackageReference for package 'NAudio' added to '/some-project/src/Web/UiComponents/Zezo.UiComponents.csproj'  and PackageVersion added to central package management file '/some-project/src/Directory.Packages.props'.

After the update, the project is the second argument and the Directory.Packages.Props file is the last argument.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@Nigusu-Allehu Nigusu-Allehu requested a review from a team as a code owner October 1, 2024 20:19
@Nigusu-Allehu Nigusu-Allehu marked this pull request as draft October 1, 2024 20:19
@Nigusu-Allehu Nigusu-Allehu changed the title Dev nyenework swap Swap arguments order for centralized package version logs Oct 1, 2024
@Nigusu-Allehu Nigusu-Allehu self-assigned this Oct 1, 2024
@Nigusu-Allehu Nigusu-Allehu marked this pull request as ready for review October 1, 2024 21:51
@Nigusu-Allehu Nigusu-Allehu marked this pull request as draft October 1, 2024 21:51
@Nigusu-Allehu Nigusu-Allehu marked this pull request as ready for review October 2, 2024 17:42

var msObject = new MSBuildAPIUtility(logger: new TestLogger());
var logger = new TestLogger();
var msObject = new MSBuildAPIUtility(logger: logger);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var msObject = new MSBuildAPIUtility(logger: logger);
var msObject = new MSBuildAPIUtility(logger);

@Nigusu-Allehu Nigusu-Allehu requested a review from zivkan October 4, 2024 20:55
@Nigusu-Allehu Nigusu-Allehu merged commit a41fd92 into dev Oct 10, 2024
28 checks passed
@Nigusu-Allehu Nigusu-Allehu deleted the dev-nyenework-swap branch October 10, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong order of arguments in logs for centralized package version (string Info_AddPkgCPM)
3 participants