Remove TestableVSCredentialProvider #6084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
reviewed
Oct 7, 2024
test/TestExtensions/TestableVSCredentialProvider/TestableVSCredentialProvider.csproj
Show resolved
Hide resolved
kartheekp-ms
reviewed
Oct 7, 2024
kartheekp-ms
approved these changes
Oct 9, 2024
|
Thank you @donnie-msft for fixing this issue. I have encountered it multiple times but didn't get a chance to fix the issue. |
nkolev92
approved these changes
Oct 9, 2024
zivkan
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13836
Description
One of our test utilities attempts to generate a document without a set path, so that path becomes the root. In this case,
C:\.xml.The build shouldn't be writing to my root drive.
I tracked down this task item being responsible for the behavior:
DocumentationProjectOutputGroupOutputI attempted to set the OutputPath in this project, but it didn't change the behavior. I'm thinking since this is not an SDK style project, and it's not one of our source code projects, it's not respecting the OutputPath.
Looking for where this utility is used, I was unable to find any references to it. We have credential provider test fixtures and mocking that looks like is covering these test scenarios. Therefore, I propose removing it.
PR Checklist