Skip PushCommand_AllowsTimeoutToBeSpecifiedHigherThan100Seconds and PushCommand_AllowsTimeoutToBeSpecifiedLowerThan100Seconds #6087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
added
the
Engineering
nkolev92
previously approved these changes
Oct 8, 2024
donnie-msft
reviewed
Oct 8, 2024
…ushCommand_AllowsTimeoutToBeSpecifiedLowerThan100Seconds
jeffkl
force-pushed
the
dev-jeff-fix-test-hang
branch
from
b97e621
to
7d08df5
Compare
zivkan
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3045
Description
These two tests check if a user can override the default timeout, which is now 5 minutes (300 seconds). We could update the tests but the one that verifies you can specify a longer timeout runs for over 100 seconds which seems wasteful. The one that checks that you can specify a shorter timeout appears to hang occasionally. I don't think either test is providing any value at this point.
PR Checklist