Fix GetResolvedVersions_WithAPackageInDirectoryBuildProps_GetsVersion and GetResolvedVersions_WithAPackageInDirectoryPackageProps_GetsVersion #6088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and GetResolvedVersions_WithAPackageInDirectoryPackageProps_GetsVersion
jeffkl
added
Engineering
|
Maybe because of our own Directory.Packages.props in the root of our repo? |
nkolev92
approved these changes
Oct 8, 2024
Shouldn't be affecting tests, we write empty files at the root of |
jebriede
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Description
I'm not sure how these tests ever worked but they started failing presumably because of a deployment in ADO.
PR Checklist