Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XMLDoc comments on public PackageExtractor methods #6095

Merged
merged 4 commits into from
Oct 17, 2024

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Oct 10, 2024

Bug

related to NuGet/Home#13844

Description

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests N/A
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. N/A

@zivkan zivkan requested a review from a team as a code owner October 10, 2024 20:58
martinrrm
martinrrm previously approved these changes Oct 10, 2024
nkolev92
nkolev92 previously approved these changes Oct 11, 2024
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround 👏

This can probably resolve the linked issue btw.

nkolev92
nkolev92 previously approved these changes Oct 16, 2024
@zivkan zivkan merged commit b624fbe into dev Oct 17, 2024
29 of 32 checks passed
@zivkan zivkan deleted the dev-zivkan-path-resolver-comments branch October 17, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants