-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move signed package testing utils to new package #6100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a bunch of test failures, not sure where that got broken.
The change looks as expected. I'd love to chat about the package name, but we can do that later in the PR meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR fixes https://github.com/NuGet/Client.Engineering/issues/543 as well. |
63da05a
to
ffc80b8
Compare
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/3051
Fixes: https://github.com/NuGet/Client.Engineering/issues/543
Description
NuGetGallery uses some of the signed package utilities from this repo's
Test.Utility
assembly. However, this project is used as a place to put pretty much any shared test utility in the repo, including for test utility classes for NuGet.Client's VS code. This means the project has project references to some VS assemblies, and therefore whenTest.Utility
is packed into a package, it has dependencies on packages that don't exist (and have no reason to exist).So, to clean up the "software architecture" a bit, I created a new assembly, moved all the signed package utilities into that new project, and updated everything.
I named the new project
Internal.NuGet.Testing.SignedPackages
, because our normal process when publishing to nuget.org is to create an API key for thenuget.*
namespace, and by starting this package withinternal.*
, it reduces the risk that this package accidentally gets pushed to nuget.org.PR Checklist
Added testsn/aLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.n/a