Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move signed package testing utils to new package #6100

Merged
merged 8 commits into from
Oct 17, 2024

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Oct 14, 2024

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/3051
Fixes: https://github.com/NuGet/Client.Engineering/issues/543

Description

NuGetGallery uses some of the signed package utilities from this repo's Test.Utility assembly. However, this project is used as a place to put pretty much any shared test utility in the repo, including for test utility classes for NuGet.Client's VS code. This means the project has project references to some VS assemblies, and therefore when Test.Utility is packed into a package, it has dependencies on packages that don't exist (and have no reason to exist).

So, to clean up the "software architecture" a bit, I created a new assembly, moved all the signed package utilities into that new project, and updated everything.

I named the new project Internal.NuGet.Testing.SignedPackages, because our normal process when publishing to nuget.org is to create an API key for the nuget.* namespace, and by starting this package with internal.*, it reduces the risk that this package accidentally gets pushed to nuget.org.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests n/a
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. n/a

@zivkan zivkan requested a review from a team as a code owner October 14, 2024 10:38
@zivkan zivkan requested a review from agr October 14, 2024 10:42
Copy link
Member

@nkolev92 nkolev92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of test failures, not sure where that got broken.

The change looks as expected. I'd love to chat about the package name, but we can do that later in the PR meeting.

agr
agr previously approved these changes Oct 15, 2024
Copy link
Contributor

@agr agr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nkolev92
Copy link
Member

@zivkan zivkan requested a review from nkolev92 October 16, 2024 11:02
@zivkan zivkan merged commit b8efbf3 into NuGet:dev Oct 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants