Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update System.Text.Json. (#6101)" #6123

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Oct 28, 2024

This reverts commit fbb1d63.

Bug

Fixes: engineering issue

Description

Our insertions into the .NET SDK are blocked because the dnceng infrastructure uses public versions of Visual Studio, which do not yet have this newer version of System.Text.Json.

We'll need to reapply the fix once dnceng agents have a newer VS available.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue (engineering issue)
  • Added tests no product changes
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. no product changes

@zivkan zivkan requested a review from a team as a code owner October 28, 2024 22:09
Copy link
Contributor

@donnie-msft donnie-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked 6.12 branch and did not find this needs to be reverted there.

@zivkan zivkan merged commit fad3153 into dev Oct 29, 2024
29 of 32 checks passed
@zivkan zivkan deleted the dev-zivkan-revert-system.text.json-upgrade branch October 29, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants