Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable manual GitHub status for PrivateDev #6128

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Disable manual GitHub status for PrivateDev #6128

merged 1 commit into from
Oct 30, 2024

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Oct 29, 2024 •
edited
Loading

Bug

Fixes:

Description

Since making the PrivateDev pipeline trigger for pull requests, the manual GitHub status isn't needed. The pipeline reports itself now.

Once this is merged, we should remove the required checks Build_and_UnitTest_NonRTM and Build_and_UnitTest_RTM, but add NuGet.Client-PrivateDev.

image

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@jeffkl jeffkl self-assigned this Oct 29, 2024
@jeffkl jeffkl added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Oct 29, 2024
@jeffkl jeffkl marked this pull request as ready for review October 29, 2024 23:57
@jeffkl jeffkl requested a review from a team as a code owner October 29, 2024 23:58
@jeffkl jeffkl merged commit 2e9c4ec into dev Oct 30, 2024
21 of 23 checks passed
@jeffkl jeffkl deleted the dev-jeffkl-remove-manual-status-checks branch October 30, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivkan zivkan zivkan approved these changes

@nkolev92 nkolev92 nkolev92 approved these changes

Assignees

@jeffkl jeffkl

Labels
Engineering Changes related to the build infrastructure of the repo and that do not change product code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffkl @nkolev92 @zivkan