Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove line under Tabs in Details Pane and newline in text when there's no README #6130

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Remove line under Tabs in Details Pane and newline in text when there's no README #6130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b38a835
Reduce paragraph spacing
donnie-msft Oct 29, 2024
ba2bace
Remove grid border
donnie-msft Oct 30, 2024
dea6391
Remove TabPanel margin
donnie-msft Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/NuGet.Clients/NuGet.PackageManagement.UI/Resources.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions src/NuGet.Clients/NuGet.PackageManagement.UI/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,11 +1088,9 @@ Please see https://aka.ms/troubleshoot_nuget_cache for more help.</value>
<data name="Text_NoReadme" xml:space="preserve">
<value>Could not read package README from selected package.

Only the package maintainer can add a README.

If you are not the maintainer, please consider filing an issue or contacting the maintainer to request a README.
Only the package maintainer can add a README. If you are not the maintainer, please consider filing an issue or contacting the maintainer to request a README.

For instructions on how to add a README, please visit [aka.ms/nuget/readme](https://aka.ms/nuget/readme)</value>
<comment>{Locked="[aka.ms/nuget/readme](https://aka.ms/nuget/readme)"} "[aka.ms/nuget/readme](https://aka.ms/nuget/readme)" this is a URL link and should not be translated</comment>
</data>
</root>
</root>
10 changes: 1 addition & 9 deletions src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageDetailsTabControl.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,7 @@
<RowDefinition x:Name="RowDefinition1" Height="Auto"/>
<RowDefinition x:Name="RowDefinition2"/>
</Grid.RowDefinitions>
<TabPanel x:Name="headerPanel" Background="Transparent" Grid.Column="0" IsItemsHost="true" Margin="0,0,0,-1" Grid.Row="0" KeyboardNavigation.TabIndex="1" Panel.ZIndex="1"/>
<Rectangle
x:Name="gridBorder"
Grid.Row="1"
Height="1"
Panel.ZIndex="-1"
Margin="0,1,0,0"
HorizontalAlignment="Stretch"
Fill="{DynamicResource {x:Static SystemColors.ActiveBorderBrushKey}}"/>
<TabPanel x:Name="headerPanel" Background="Transparent" Grid.Column="0" IsItemsHost="true" Grid.Row="0" KeyboardNavigation.TabIndex="1" Panel.ZIndex="1"/>
<ContentPresenter
Grid.Row="2"
ClipToBounds="True"
Expand Down