Add ReadmeUriTemplateResource for download README from remote sources. #6136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
previously approved these changes
Nov 5, 2024
src/NuGet.Core/NuGet.Protocol/Resources/ReadmeUriTemplateResource.cs
Outdated
Show resolved
Hide resolved
zivkan
reviewed
Nov 5, 2024
There was a problem hiding this comment.
The tech spec hasn't been approved/merged yet: https://github.com/NuGet/Home/pull/13200/files
Shouldn't we get agreement on the technical approach, before implementation?
microsoft-github-policy-service
bot
added
the
Status:No recent activity
donnie-msft
reviewed
Nov 19, 2024
test/NuGet.Core.Tests/NuGet.Protocol.Tests/Providers/ReadmeUriTemplateResourceProviderTests.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Protocol/Resources/ReadmeUriTemplateResource.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
removed
the
Status:No recent activity
jgonz120
force-pushed
the
dev-jgonz120-AddReadmeUriTemplateResourceType
branch
from
4ac41a5 to
ed65992
Compare
jeffkl
previously approved these changes
Nov 21, 2024
donnie-msft
requested changes
Nov 21, 2024
src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/ReadmePreviewViewModel.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Protocol/Providers/ReadmeUriTemplateResourceProvider.cs
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Protocol/Providers/ReadmeUriTemplateResourceProvider.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Protocol/Providers/ReadmeUriTemplateResourceProvider.cs
Show resolved
Hide resolved
donnie-msft
previously approved these changes
Nov 21, 2024
jebriede
reviewed
Nov 22, 2024
src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/ReadmePreviewViewModel.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/ReadmePreviewViewModel.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Protocol/Resources/ReadmeUriTemplateResource.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Core/NuGet.Protocol/Resources/ReadmeUriTemplateResource.cs
Outdated
Show resolved
Hide resolved
jebriede
reviewed
Nov 22, 2024
src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/ReadmePreviewViewModel.cs
Outdated
Show resolved
Hide resolved
jebriede
reviewed
Nov 22, 2024
src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/ReadmePreviewViewModel.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/ReadmePreviewViewModel.cs
Outdated
Show resolved
Hide resolved
jebriede
approved these changes
Nov 22, 2024
Nigusu-Allehu
approved these changes
Nov 22, 2024
jeffkl
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2918
Description
Created a new resource type for generating the README download URI.
ReadmeUriTemplate/6.13.0is the resource we will be looking for in the service index. We use the URL set in the service index as the template for generating the URI for downloading the README.Instead of directly exposing this resource type, the PackageMetadataResourceV3 class has been updated to set the ReadmeFileUrl with the URI.
Since the README will start pulling from remote sources there may be a delay while we download the README. I've added a loading message which will be displayed in the README control.
PR Checklist