Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: clean up client certificate test resources #6143

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Test: clean up client certificate test resources #6143

merged 1 commit into from
Nov 13, 2024

Conversation

dtivel
Copy link
Contributor

@dtivel dtivel commented Nov 12, 2024

Bug

Fixes: NuGet/Home#13919

Description

This change updates client certificate tests to:

  • provide stronger guarantees that test certificates will be cleaned up after tests run
  • reduce test certificate validity periods from ~1 year to something more appropriate (~10 minutes)
  • ensure disposable objects are disposed

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests N/A
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. N/A

@dtivel dtivel requested a review from a team as a code owner November 12, 2024 21:22
@dtivel dtivel force-pushed the dev-dtivel-clean-up-test-certificates branch from 8dce6ae to a345422 Compare November 12, 2024 23:34
@dtivel dtivel merged commit 3872959 into dev Nov 13, 2024
22 of 23 checks passed
@dtivel dtivel deleted the dev-dtivel-clean-up-test-certificates branch November 13, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffkl jeffkl jeffkl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test: client certificate tests need better cleanup
2 participants
@dtivel @jeffkl