Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: ensure test certificate is removed from certificate store #6144

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

dtivel
Copy link
Contributor

@dtivel dtivel commented Nov 13, 2024

Bug

Fixes: NuGet/Home#13923

Description

This change ensures that a test certificate is removed from its certificate store upon test completion.

This change also updates the certificate subject to be clear that it is for NuGet testing. test trusted is pretty vague.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests N/A
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. N/A

@dtivel dtivel requested a review from a team as a code owner November 13, 2024 19:46
@dtivel dtivel force-pushed the dev-dtivel-clean-up-test-certificate branch from 7c4b799 to ad01440 Compare November 14, 2024 22:45
@dtivel dtivel merged commit 8fac9eb into dev Nov 15, 2024
23 checks passed
@dtivel dtivel deleted the dev-dtivel-clean-up-test-certificate branch November 15, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: test certificate not removed after test completion
2 participants