-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid recreating IMarkdownPreview control #6153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
previously approved these changes
Nov 19, 2024
microsoft-github-policy-service
bot
added
the
Status:No recent activity
PRs that have not had any recent activity and will be closed if the label is not removed
label
Nov 27, 2024
jgonz120
force-pushed
the
dev-jgonz120-AvoidRecreatingMarkdownControl
branch
from
November 27, 2024 20:13
69523d1
to
b55903f
Compare
microsoft-github-policy-service
bot
removed
the
Status:No recent activity
PRs that have not had any recent activity and will be closed if the label is not removed
label
Nov 27, 2024
zivkan
reviewed
Nov 27, 2024
src/NuGet.Clients/NuGet.PackageManagement.UI/ViewModels/PackageDetailsTabViewModel.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Status:No recent activity
PRs that have not had any recent activity and will be closed if the label is not removed
label
Dec 5, 2024
jgonz120
force-pushed
the
dev-jgonz120-AvoidRecreatingMarkdownControl
branch
from
December 6, 2024 00:03
b55903f
to
60f6b3d
Compare
microsoft-github-policy-service
bot
removed
the
Status:No recent activity
PRs that have not had any recent activity and will be closed if the label is not removed
label
Dec 6, 2024
jeffkl
previously approved these changes
Dec 10, 2024
martinrrm
previously approved these changes
Dec 10, 2024
jebriede
previously approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving w/ suggestions
src/NuGet.Clients/NuGet.PackageManagement.UI/Xamls/PackageReadmeControl.xaml.cs
Outdated
Show resolved
Hide resolved
src/NuGet.Clients/NuGet.PackageManagement.UI/Utility/MarkdownPreviewSingleton.cs
Show resolved
Hide resolved
@jgonz120 please update the description of the PR. It still says that we're using the ViewModel to create the MarkdownPreview which we no longer are doing after you incorporated my offline feedback. |
jeffkl
approved these changes
Dec 11, 2024
Nigusu-Allehu
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes:
Description
The tab control unloads the PackageReadmeControl when the tab is switched away. This was causing PackageReadmeControl to recreate the IMarkdownPreview every time the README tab was loaded. I created a singleton to ensure we reuse the MarkdownPreview.
PR Checklist
Added testsLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.