Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid recreating IMarkdownPreview control #6153

Merged
merged 8 commits into from
Dec 11, 2024

Conversation

jgonz120
Copy link
Contributor

@jgonz120 jgonz120 commented Nov 19, 2024

Bug

Fixes:

Description

The tab control unloads the PackageReadmeControl when the tab is switched away. This was causing PackageReadmeControl to recreate the IMarkdownPreview every time the README tab was loaded. I created a singleton to ensure we reuse the MarkdownPreview.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

Sorry, something went wrong.

@jgonz120 jgonz120 requested a review from a team as a code owner November 19, 2024 21:39
jeffkl
jeffkl previously approved these changes Nov 19, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Nov 27, 2024
@jgonz120 jgonz120 force-pushed the dev-jgonz120-AvoidRecreatingMarkdownControl branch from 69523d1 to b55903f Compare November 27, 2024 20:13
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Nov 27, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Dec 5, 2024
@jgonz120 jgonz120 force-pushed the dev-jgonz120-AvoidRecreatingMarkdownControl branch from b55903f to 60f6b3d Compare December 6, 2024 00:03
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status:No recent activity PRs that have not had any recent activity and will be closed if the label is not removed label Dec 6, 2024
@jeffkl jeffkl self-requested a review December 6, 2024 22:47
jeffkl
jeffkl previously approved these changes Dec 10, 2024
martinrrm
martinrrm previously approved these changes Dec 10, 2024
jebriede
jebriede previously approved these changes Dec 10, 2024
Copy link
Contributor

@jebriede jebriede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving w/ suggestions

@jebriede
Copy link
Contributor

@jgonz120 please update the description of the PR. It still says that we're using the ViewModel to create the MarkdownPreview which we no longer are doing after you incorporated my offline feedback.

@jgonz120 jgonz120 dismissed stale reviews from jebriede, martinrrm, and jeffkl via b713956 December 11, 2024 00:04
@jgonz120 jgonz120 requested review from jebriede and jeffkl December 11, 2024 00:48
@jgonz120 jgonz120 requested a review from martinrrm December 11, 2024 00:48
@jgonz120 jgonz120 merged commit ece3bfe into dev Dec 11, 2024
23 checks passed
@jgonz120 jgonz120 deleted the dev-jgonz120-AvoidRecreatingMarkdownControl branch December 11, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants