Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable code sign verification for loc artifact #6175

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Nov 28, 2024

Bug

follow up from #6170

Description

The main point of the work was to re-enable code sign verification, and when reviewing the other pull request, I completely forgot! 🤦

While I was at it, I updated all the binlog filenames, so anyone investigating build failures have slightly less cognitive load.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@zivkan zivkan added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Nov 28, 2024
@zivkan zivkan requested a review from a team as a code owner November 28, 2024 01:15
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@zivkan zivkan merged commit 17ee4b3 into dev Dec 5, 2024
23 checks passed
@zivkan zivkan deleted the dev-zivkan-code-sign-verification-loc branch December 5, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Changes related to the build infrastructure of the repo and that do not change product code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants