remove some redundant variable assignments #6184
Conversation
microsoft-github-policy-service
bot
added
the
Community
microsoft-github-policy-service
bot
added
the
Status:No recent activity
There was a problem hiding this comment.
Thank you for your contributions! Out of curiosity and for learning purposes, did you identify these redundant assignments manually by reviewing all our code, or did you use a script to help with that? It seems like it would be a lot of effort to do manually, and I'm impressed either way!
microsoft-github-policy-service
bot
removed
the
Status:No recent activity
|
@Nigusu-Allehu i use a variety of techniques and tools. usually i just open random file and review them. often starting with the larger files. when i find a problem/improvement i work out some approach to finding any other instances of that problem/improvement. this approach can be varied: a test that uses roslyn, a regex search, features provided by an ide, etc in this case it was relatively easy given rider has a feature that will find redundant variable assignments |
…t-variable-assignments
| @@ -70,7 +70,7 @@ public NuGetProject TryCreateNuGetProject( | |||
| // Treat projects with project.json as build integrated projects | |||
| // Search for projectName.project.json first, then project.json | |||
| // If the name cannot be determined, search only for project.json | |||
| string projectJsonPath = null; | |||
| string projectJsonPath; | |||
There was a problem hiding this comment.
I'd feel more strongly about accepting this PR if it was coupled with a rule change as well: https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0059.
Bug
Fixes:
Description
remove some redundant variable assignments
PR Checklist