Fix floating version comparison in new dependency resolver #6187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinrrm
previously approved these changes
Dec 9, 2024
zivkan
previously approved these changes
Dec 10, 2024
test/NuGet.Core.FuncTests/NuGet.Commands.FuncTest/RestoreCommand_AlgorithmEquivalencyTests.cs
Outdated
Show resolved
Hide resolved
Nigusu-Allehu
previously approved these changes
Dec 10, 2024
jgonz120
previously approved these changes
Dec 10, 2024
jeffkl
force-pushed
the
dev-jeffkl-floating-versions
branch
from
fcc3fd9 to
2135e69
Compare
nkolev92
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13992
Description
The dependency resolver uses a comparison that was not taking into account floating versions. This is because the
VersionRangeobject has special logic that was missed:NuGet.Client/src/NuGet.Core/NuGet.Versioning/VersionRange.cs
Lines 429 to 430 in acc521c
This change updates the version range comparison to take into account floating versions which fixes the reported issue where restore is resolving the wrong graph in some situations.
PR Checklist