Update dependency resolver to never download packages eclipsed by direct references #6188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
changed the title
donnie-msft
previously approved these changes
Dec 13, 2024
test/NuGet.Core.FuncTests/NuGet.Commands.FuncTest/RestoreCommand_AlgorithmEquivalencyTests.cs
Show resolved
Hide resolved
jeffkl
force-pushed
the
dev-jeffkl-fix-overdownload
branch
from
f394370 to
562781d
Compare
jgonz120
approved these changes
Dec 16, 2024
nkolev92
approved these changes
Dec 17, 2024
|
thanks @jeffkl, is it a candidate of 9.0 backport? |
|
@kasperk81 Potentially, we're assessing that now but will decide in January. At the very least it will be in Visual Studio 17.13 Preview 3 and .NET 9.0.200. |
that's what i was hoping for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13943
Description
The new dependency resolver is optimized to download all packages in parallel. However, we don't want transitive packages to be downloaded if they are eclipsed by a direct reference. This is because the direct reference will always win so there's no point in downloading it. There's also a pattern of users adding direct dependencies to avoid downloading vulnerable packages.
This change creates a
HashSet<int>containing the interned value of the package name for all direct package references and then skip them if a transitive package is found with the same ID. This could potentially make dependency resolution a little faster depending on how many direct package references are specified.PR Checklist