Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update System.Text.Json and add docs about updating packages #6199

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Dec 16, 2024

Bug

Fixes: NuGet/Home#13857

Description

  • Update System.Text.Json to 8.0.5
  • Add docs to explain why we can't always immediately update to the latest versions of certain packages
  • Add comments to the two most impacted packages in Directory.Packages.props instructing the developer to read the docs before upgrading those two package versions.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests N/A
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. N/A

@zivkan zivkan requested a review from a team as a code owner December 16, 2024 20:38
Copy link
Contributor

@jeffkl jeffkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@zivkan zivkan merged commit 8791d42 into dev Dec 18, 2024
23 checks passed
@zivkan zivkan deleted the dev-zivkan-system.text.json-8.0.5 branch December 18, 2024 09:51
@ericstj
Copy link
Contributor

ericstj commented Jan 8, 2025

Which Version of VS and MSBuild do you require for this change? Can you make sure you mention that and confirm it when making these changes in the future?

This mentions 17.10.4 -- but that's still using older System.Text.Json https://www.nuget.org/packages/Microsoft.Build/17.10.4#dependencies-body-tab

@ViktorHofer @rainersigwald

@zivkan
Copy link
Member Author

zivkan commented Jan 15, 2025

@ericstj at the time this PR was merged into the dev branch, NuGet was going into VS/MSBuild 17.13, and the 9.0.2xx .NET SDK. NuGet's insertion into both products, and their respective CI builds, were successful, which would have not been the case if those products were still using older versions of STJ. In fact, dnceng was late to make VS 17.13 previews available on Helix, and the .NET SDK team had to use a different Helix agent pool/image for tests to pass.

I hope that answers your question, because it's less than NuGet "depends" on MSBuild, but rather NuGet inserts into other products that also ship MSBuild.

@ericstj
Copy link
Contributor

ericstj commented Jan 21, 2025

Yeah, I was just looking for some statement in the PR or in the changes that says "This change requires VS version XXX" - it can be helpful when seeing codeflow failures if things are running with older versions. It can help identify which thing needs to change -- in this case we needed to get consuming repositories to update their version of VS used to build.

@nkolev92
Copy link
Member

In a large number of cases, we end up tagging the commit with the first build number that gets inserted.

image

This tells us it's 6.13, matchig 17.13 (major is VS - 11, minor is always the same)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Text.Json 8.0.4 has security vulnerability
5 participants