fixed https://github.com/NuGet/Home/issues/1196 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _detailModel.Options.ShowPreviewWindow = settings.ShowPreviewWindow; | ||
| _detailModel.Options.RemoveDependencies = settings.RemoveDependencies; | ||
| _detailModel.Options.ForceRemove = settings.ForceRemove; | ||
| _topPanel.CheckboxPrerelease.IsChecked = settings.IncludePrerelease; | ||
|
|
||
| SetSelectedDepencyBehavior(settings.DependencyBehavior); | ||
| SetSelectedDepencyBehavior(GetDependencyBehaviorFromConfig(nugetSettings)?? settings.DependencyBehavior); |
There was a problem hiding this comment.
To make this easier to debug create a new var for the value before passing it into SetSelectedDepencyBehavior. There should be a space before ?? also.
|
It looks like the null checks for both settings and nugetSettings have been dropped in the new code, shouldn't this be handled still? ⌚ |
| @@ -166,6 +166,7 @@ public void ApplyShowPreviewSetting(bool show) | |||
| UserSettings settings, | |||
| Configuration.ISettings nugetSettings) | |||
| { | |||
| var dependencySetting = GetDependencyBehaviorFromConfig(nugetSettings); | |||
There was a problem hiding this comment.
nugetSettings can be null here, which will throw
|
⌚ |
| Configuration.ISettings nugetSettings) | ||
| { | ||
| if (nugetSettings == null) |
There was a problem hiding this comment.
It's already returning null at the bottom by default, you can just add this if around the method body to make things more clear
|
🚀 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet/Home#1196
the bug is UI don't show the value of DependencyVersion in config as default.
the fix is during UI loading, it will check DependencyVersion in config, if there is a config setting there, use that as dependency Behavior value.